[libvirt] [PATCHv2 0/4] VMX: CD-ROM handling improvements

Doug Goldstein cardoe at cardoe.com
Fri Aug 23 01:53:05 UTC 2013


A user came into #virt the other day and was trying to get libvirtd
to work with VMWare Fusion 5, which is basically the Mac OS X version of
VMWare Workstation. In helping him out I noticed a few limitations of our
VMX parser so I've added support through this patchset. However I came
across the fact that we only support 2 types of CD-ROMs instead of the 3
types that VMWare has lead to adding support for a <driver> element to
CD-ROM drives. Additionally VMWare Fusion has a concept of auto detecting
your host CD-ROM drive at boot and we don't have a XML field for this so
I omitted a <source> element and added the tray to be opened.

Doug Goldstein (4):
  VMX: Add cdrom-raw dev type from VMWare Fusion
  VMX: Add support for 'auto detect' fileNames
  VMX: Some serial ports are not actually connected
  VMX: Add a VMWare Fusion 5 configuration for tests

 docs/formatdomain.html.in                          |  3 +-
 src/vmx/vmx.c                                      | 61 ++++++++++++---
 tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml     |  1 +
 .../vmx2xml-cdrom-ide-raw-auto-detect.vmx          |  5 ++
 .../vmx2xml-cdrom-ide-raw-auto-detect.xml          | 24 ++++++
 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-device.vmx |  5 ++
 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-device.xml | 25 ++++++
 tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml    |  1 +
 .../vmx2xml-cdrom-scsi-raw-auto-detect.vmx         |  6 ++
 .../vmx2xml-cdrom-scsi-raw-auto-detect.xml         | 24 ++++++
 .../vmx2xmldata/vmx2xml-cdrom-scsi-raw-device.vmx  |  6 ++
 .../vmx2xmldata/vmx2xml-cdrom-scsi-raw-device.xml  | 25 ++++++
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml    |  1 +
 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 88 ++++++++++++++++++++++
 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml | 39 ++++++++++
 tests/vmx2xmltest.c                                |  6 ++
 .../xml2vmxdata/xml2vmx-cdrom-ide-atapi-device.vmx | 13 ++++
 .../xml2vmxdata/xml2vmx-cdrom-ide-atapi-device.xml | 15 ++++
 .../xml2vmx-cdrom-ide-raw-auto-detect.vmx          | 14 ++++
 .../xml2vmx-cdrom-ide-raw-auto-detect.xml          | 14 ++++
 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-device.vmx | 13 ++++
 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-device.xml | 15 ++++
 .../xml2vmx-cdrom-scsi-atapi-device.vmx            | 14 ++++
 .../xml2vmx-cdrom-scsi-atapi-device.xml            | 15 ++++
 .../xml2vmx-cdrom-scsi-raw-auto-detect.vmx         | 15 ++++
 .../xml2vmx-cdrom-scsi-raw-auto-detect.xml         | 14 ++++
 .../xml2vmxdata/xml2vmx-cdrom-scsi-raw-device.vmx  | 14 ++++
 .../xml2vmxdata/xml2vmx-cdrom-scsi-raw-device.xml  | 15 ++++
 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 30 ++++++++
 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml | 40 ++++++++++
 tests/xml2vmxtest.c                                |  8 ++
 31 files changed, 558 insertions(+), 11 deletions(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-auto-detect.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-auto-detect.xml
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-device.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-device.xml
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-auto-detect.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-auto-detect.xml
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-device.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-device.xml
 create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-atapi-device.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-atapi-device.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-auto-detect.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-auto-detect.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-device.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-device.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-atapi-device.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-atapi-device.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-auto-detect.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-auto-detect.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-device.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-device.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml

-- 
1.8.1.5




More information about the libvir-list mailing list