[libvirt] [PATCH] virNetDevVethCreate: assign names based on mac address by default
Daniel P. Berrange
berrange at redhat.com
Thu Aug 29 09:38:27 UTC 2013
On Thu, Aug 29, 2013 at 12:05:49AM +0300, Oskari Saarenmaa wrote:
> Interface names do not have to be numerical (or veth + number) and trying to
> assign them to that format is susceptible to race conditions. Instead,
> assign the parent interface name according to the mac address (the last
> three bytes) if no name was given by the caller and use the parent interface
> name plus 'p' for the container name.
>
> Signed-off-by: Oskari Saarenmaa <os at ohmu.fi>
NACK, I really don't like this proposed naming scheme. If there is a rac
with our current code we should be fixing that race.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list