[libvirt] [PATCH] qemu: default to vfio for nodedev-detach

Eric Blake eblake at redhat.com
Mon Dec 2 16:58:49 UTC 2013


On 11/29/2013 04:47 AM, Laine Stump wrote:
> This patch resolves:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1035188
> 
> Commit f094aaac48a6 changed the PCI device assignment in qemu domains
> to default to using VFIO rather than legacy KVM device assignment
> (when VFIO is available). It didn't change which driver was used by
> default for virNodeDeviceDetachFlags(), though, so that API (and the
> virsh nodedev-detach command) was still binding to the pci-stub
> driver, used by legacy KVM assignment, by default.
> 
> This patch publicizes (only within the qemu module, though, so no
> additions to the symbol exports are needed) the functions that check
> for presence of KVM and VFIO device assignment, then uses those
> functions to decide what to do when no driver is specified for
> virNodeDeviceDetachFlags(); if the vfio driver is loaded, the device
> will be bound to vfio-pci, or if legacy KVM assignment is supported on
> this system, the device will be bound to pci-stub; if neither method
> is avialable, the detach will fail.

s/avialable/available/

> ---
>  src/qemu/qemu_driver.c  | 19 ++++++++++++++++---
>  src/qemu/qemu_hostdev.c |  6 +++---
>  src/qemu/qemu_hostdev.h |  4 +++-
>  3 files changed, 22 insertions(+), 7 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131202/1fac7535/attachment-0001.sig>


More information about the libvir-list mailing list