[libvirt] [PATCH]lxc: remove redundant mount operation

Chen Hanxiao chenhanxiao at cn.fujitsu.com
Tue Dec 3 08:37:15 UTC 2013


ping

> -----Original Message-----
> From: Chen Hanxiao [mailto:chenhanxiao at cn.fujitsu.com]
> Sent: Friday, November 08, 2013 4:31 PM
> To: libvir-list at redhat.com
> Cc: chenhanxiao at cn.fujitsu.com
> Subject: [libvirt][PATCH]lxc: remove redundant mount operation
> 
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> If we do not specify a readonly mount, we don't need to
> re-mount it again.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  src/lxc/lxc_container.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
> index 255c711..351217a 100644
> --- a/src/lxc/lxc_container.c
> +++ b/src/lxc/lxc_container.c
> @@ -1126,13 +1126,6 @@ static int
> lxcContainerMountFSBind(virDomainFSDefPtr fs,
>                                   _("Failed to make directory %s
> readonly"),
>                                   fs->dst);
>          }
> -    } else {
> -        VIR_DEBUG("Binding %s readwrite", fs->dst);
> -        if (mount(src, fs->dst, NULL, MS_BIND|MS_REMOUNT, NULL) < 0) {
> -            virReportSystemError(errno,
> -                                 _("Failed to make directory %s
> readwrite"),
> -                                 fs->dst);
> -        }
>      }
> 
>      ret = 0;
> --
> 1.8.2.1






More information about the libvir-list mailing list