[libvirt] [PATCH] qemu: report error on attempt to live change virtio-net queues

Laine Stump laine at laine.org
Tue Dec 3 10:43:47 UTC 2013


This resolves:

  https://bugzilla.redhat.com/show_bug.cgi?id=1029732

The BZ asked for the capability to change the number of queues used by
a virtio-net device while the device is in use. Because the number of
queues can only be set at the time the device is created, that isn't
possible. However, libvirt also shouldn't be silently reporting
success when someone tries to change the number of queues. So this
patch flags that as an error (just as attempts to change any of the
other virtio-specific parameters already do).
---
 src/qemu/qemu_hotplug.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 649c884..c136232 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1899,7 +1899,8 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
         (olddev->driver.virtio.name != newdev->driver.virtio.name ||
          olddev->driver.virtio.txmode != newdev->driver.virtio.txmode ||
          olddev->driver.virtio.ioeventfd != newdev->driver.virtio.ioeventfd ||
-         olddev->driver.virtio.event_idx != newdev->driver.virtio.event_idx)) {
+         olddev->driver.virtio.event_idx != newdev->driver.virtio.event_idx ||
+         olddev->driver.virtio.queues != newdev->driver.virtio.queues)) {
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                        _("cannot modify virtio network device driver attributes"));
         goto cleanup;
-- 
1.8.4.2




More information about the libvir-list mailing list