[libvirt] [PATCH 1/5] nwfilter: Remove Coverity DEADCODE warning

Eric Blake eblake at redhat.com
Tue Dec 3 16:37:31 UTC 2013


On 12/03/2013 07:18 AM, John Ferlan wrote:
> The nwfilterStateInitialize() would only assign sysbus inside
> a WITH_DBUS conditional, thus leavin a subsequent check for sysbus

s/leavin/leaving/

> and nwfilterDriverInstallDBusMatches() as a no-op
> 
> Rather than try to add WITH_DBUS conditions which ended up conflicting
> with the usage of HAVE_FIREWALLD conditionals, just remove the WITH_DBUS
> since virdbus.c has entry points for with and without conditions.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/nwfilter/nwfilter_driver.c | 2 --
>  1 file changed, 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131203/146e9079/attachment-0001.sig>


More information about the libvir-list mailing list