[libvirt] [PATCH] virThreadPoolFree: Join worker threads

[Eric Blake]

On 12/04/2013 06:05 AM, Michal Privoznik wrote:
> Even though currently we are freeing the pool of worker threads at the
> daemon very end, nothing holds us back in joining the worker threads.
> Moreover, we avoid leaks like this:
> 
> ==26697== 1,680 bytes in 5 blocks are possibly lost in loss record 913 of 942
> ==26697==    at 0x4C2BDE4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==26697==    by 0x4011131: allocate_dtv (in /lib64/ld-2.16.so)
> ==26697==    by 0x401176D: _dl_allocate_tls (in /lib64/ld-2.16.so)
> ==26697==    by 0x8499602: pthread_create@@GLIBC_2.2.5 (in /lib64/libpthread-2.16.so)
> ==26697==    by 0x52F53E9: virThreadCreate (virthreadpthread.c:188)
> ==26697==    by 0x52F5D4F: virThreadPoolNew (virthreadpool.c:221)
> ==26697==    by 0x53F30DB: virNetServerNew (virnetserver.c:377)
> ==26697==    by 0x11C6ED: main (libvirtd.c:1366)
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/util/virthreadpool.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131204/65a42f62/attachment-0001.sig>