[libvirt] [PATCH 4/5] domainsnapshotxml2xmltest: Add existing files as new tests

Eric Blake eblake at redhat.com
Wed Dec 4 18:21:06 UTC 2013


On 12/04/2013 10:55 AM, Peter Krempa wrote:
> There were plenty snapshot XMLs in the tests/domainsnapshotxml2xmlin
> directory that actually weren't used in XML testing. The upgraded
> domainsnapshotxml2xml test now allows us to use them.

They WERE used in domainsnapshotschematest, for RNG validation, but I
agree that enhancing the xml2xml test to also test them through the C
code and not just RNG validation is a good move.

> ---
>  tests/domainsnapshotxml2xmlin/external_vm.xml           |  1 -
>  tests/domainsnapshotxml2xmlin/noparent.xml              |  1 +
>  tests/domainsnapshotxml2xmlout/disk_snapshot.xml        | 15 +++++++++++++++
>  tests/domainsnapshotxml2xmlout/empty.xml                |  8 ++++++++
>  tests/domainsnapshotxml2xmlout/external_vm.xml          |  5 +++++
>  tests/domainsnapshotxml2xmlout/name_and_description.xml |  5 +++++
>  tests/domainsnapshotxml2xmlout/noparent.xml             |  2 +-
>  tests/domainsnapshotxml2xmltest.c                       | 10 ++++++++++
>  8 files changed, 45 insertions(+), 2 deletions(-)
>  create mode 100644 tests/domainsnapshotxml2xmlout/disk_snapshot.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/empty.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/external_vm.xml
>  create mode 100644 tests/domainsnapshotxml2xmlout/name_and_description.xml
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131204/22f11716/attachment-0001.sig>


More information about the libvir-list mailing list