[libvirt] [PATCH] qemu: snapshot: Fix incorrect disk type for auto-generated disks

[Peter Krempa]

On 12/05/13 20:25, Eric Blake wrote:
> On 12/05/2013 09:30 AM, Peter Krempa wrote:
>> On 12/05/13 17:17, Peter Krempa wrote:
>>> When changing the parsing and formatting functions in commit
>>> 43f2ccdc73090bd03f64de4d58d46ffa0134d705 I forgot to update the qemu
>>> disk alingnment function for snapshots that automatically adds snapshot
> 
> s/alingnment/alignment/
> 
>>> configs for disks that were not mentioned in the XML. The function
>>> allocated a new disk snapshot definition but did not correctly
>>> initialize the snapshot disk source type variable. This resulted into
>>> the disks considered as block devices and invalid XML was generated.
>>>
> 
>>> +            if (disk->type != VIR_DOMAIN_DISK_TYPE_FILE ||
>>
>> I forgot to amend the patch before sending. Please consider && in place
>> of || in the line above.
>>
>>> +                disk->type != -1) {
>>> +                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>>> +                               _("cannot generate external snapshot name "
>>> +                                 "for disk '%s' on a '%s' device"),
> 
> ACK as amended.
> 

I've fixed the commit message and pushed this patch.

Thanks.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131206/c22ce078/attachment-0001.sig>