[libvirt] [PATCH 3/6] virtlockd: treat SIGHUP like SIGUSR1

Tue Dec 10 13:33:12 UTC 2013

On Tue, Dec 10, 2013 at 06:28:06AM -0700, Eric Blake wrote:
> On 12/10/2013 04:15 AM, Daniel P. Berrange wrote:
> > On Mon, Dec 09, 2013 at 05:23:27PM +1100, Michael Chapman wrote:
> >> SIGHUP is commonly used to instruct a daemon to reload its config. For
> >> now we should handle it in virtlockd just like SIGUSR1, rather than
> >> having it kill the process.
> > 
> > I don't think we should make SIGHUP do a re-exec - we should keep this
> > signal available for the future when we may well want to support reload
> > of the config without re-exec'ing at the same time.
> 
> Fair point; should we go ahead and revert this patch, since it got pushed?

Yep, I think that would be best.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|