[libvirt] [PATCH] storage: show compile options in virsh --version=long

[Eric Blake]

On 12/11/2013 08:38 PM, Doug Goldstein wrote:
> On Wed, Dec 11, 2013 at 9:10 PM, Eric Blake <eblake at redhat.com> wrote:
>> Adding output to 'virsh --version=long' makes it easier to
>> tell if a distro built with particular libraries (it doesn't
>> tell you what a remote libvirtd is built with, but is still
>> better than nothing).
>>

>>From a code stand point this is fine. But the commit subject and
> message are ambiguous and don't really explain what you're doing. It
> seems like you're adding all storage compile options into the output
> when really they were there already and just Gluster was missing.
> Wouldn't be better to say "storage: show gluster option in virsh
> --version=long"?

Sure, that sounds nicer.

> 
> I realize I'm nitpicking the commit message/subject, the code is fine
> so ACK from that stand point.

Amended and pushed

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131211/f39d9e88/attachment-0001.sig>