[libvirt] [v7 2/6] change qemu driver to use hostdev common library

[Chunyan Liu]

2013/12/17 Jim Fehlig <jfehlig at suse.com>

> Chunyan Liu wrote:
> > Change qemu driver to use hostdev common library instead of APIs in
> > qemu_hostdev.[ch]
> >
>
> This patch causes 'make check' to fail qemuxml2xmltest and
> qemuargv2xmltest tests.  Also, there's a segfault when running
> qemuhotplugtest.
>
>

Hi, Jim,
I'm a little confused about the qemuhotplugtest segfault since last time
you mentioned it. On my machine, qemuhotplugtest is OK (PASSED).
Both "OK" with "make check" and run the same command below.

~/upstream/libvirt/tests> libtool --mode=execute gdb qemuhotplugtest
> (gdb) r
> ...
> Program received signal SIGSEGV, Segmentation fault.
> 0x00007ffff7a6ed64 in virLockManagerPluginGetDriver (plugin=0x0) at
> locking/lock_manager.c:291
> 291        return plugin->driver;
> (gdb) bt
> #0  0x00007ffff7a6ed64 in virLockManagerPluginGetDriver (plugin=0x0) at
> locking/lock_manager.c:291
> #1  0x00007ffff7a6fc3f in virDomainLockManagerNew (plugin=0x0,
> uri=0x4fb743 "qemu:///session",
>     dom=0x7464f0, withResources=false) at locking/domain_lock.c:132
> #2  0x00007ffff7a702a9 in virDomainLockDiskAttach (plugin=0x0,
> uri=0x4fb743 "qemu:///session",
>     dom=0x7464f0, disk=0x75f240) at locking/domain_lock.c:256
> #3  0x0000000000456010 in qemuDomainAttachVirtioDiskDevice (conn=0x0,
> driver=0x72eba0 <driver>,
>     vm=0x7464f0, disk=0x75f240) at qemu/qemu_hotplug.c:257
> #4  0x0000000000457d06 in qemuDomainAttachDeviceDiskLive (conn=0x0,
> driver=0x72eba0 <driver>,
>     vm=0x7464f0, dev=0x75eab0) at qemu/qemu_hotplug.c:777
> #5  0x000000000041d1a4 in testQemuHotplugAttach (vm=0x7464f0,
> dev=0x75eab0) at qemuhotplugtest.c:109
> #6  0x000000000041d83c in testQemuHotplug (data=0x7fffffffdc90) at
> qemuhotplugtest.c:279
> #7  0x000000000041ef7b in virtTestRun (title=0x4eea60 "hotplug-base
> ATTACH disk-virtio",
>     body=0x41d46e <testQemuHotplug>, data=0x7fffffffdc90) at
> testutils.c:138
> #8  0x000000000041e195 in mymain () at qemuhotplugtest.c:430
> #9  0x0000000000420291 in virtTestMain (argc=1, argv=0x7fffffffe258,
> func=0x41da09 <mymain>)
>     at testutils.c:593
> #10 0x000000000041ebc5 in main (argc=1, argv=0x7fffffffe258) at
> qemuhotplugtest.c:487
>
> I think we discussed all of these on IRC last week.  Did you forget to
> update this patch? :)
>

Sorry, about improving qemuxml2xmltest and qemuargv2xmltest, I supposed
it should be looked at by someone else and made changes. Well, I'll modify
that first.


>
> Regards,
> Jim
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131217/25942ab5/attachment-0001.htm>