[libvirt] Implementation deficiency in virInitctlSetRunLevel

[Reco]

 Hi.

On Wed, 18 Dec 2013 18:15:17 +0100
Michal Privoznik <mprivozn at redhat.com> wrote:

> While the part above looks okay, I think we should report error if the /dev/initctl is not a pipe. Moreover, with your approach, if it's really not a pipe, we don't call open() and proceed to safewrite(-1, ...) at line 153 which will report EBADF error.

I've adjusted the patch to your suggestion.


> Missing ';' at EOL ^^^ - I guess you missed that during copy-paste.

OOPS. My mistake.

 
> Looking forward to v2.

Attached. I've tried following Daniel suggestions too.


> BTW: consider using git when sending patches. I couldn't really apply this patch via 'git am'.

I cannot figure out how to force 'git send-email' to reply on a mail.
It seems to insist to send a new one.

Reco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Don-t-write-to-non-pipes-v2.patch
Type: text/x-diff
Size: 3844 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131218/92539b20/attachment-0001.bin>