[libvirt] [PATCH RFC 09/27] storage: Add gluster pool filter and fix virsh pool listing
Eric Blake
eblake at redhat.com
Thu Dec 19 04:54:23 UTC 2013
On 12/16/2013 09:32 AM, Peter Krempa wrote:
> Recent adition of the gluster pool type omitted fixing the virsh and
s/adition/addition/
> virConnectListAllStoragePool filters. A typecast of the converting
> function in virsh showed that also the sheepdog pool was omitted in the
> command parser.
>
> This patch adds gluster pool filtering support and fixes virsh to
> properly convert all supported storage pool types. The added typecast
> should avoid doing such mistakes in the future.
> ---
> include/libvirt/libvirt.h.in | 1 +
> src/conf/storage_conf.c | 4 +++-
> tools/virsh-pool.c | 9 +++++++--
> 3 files changed, 11 insertions(+), 3 deletions(-)
Missing a doc change in virsh.pod, to mention that 'gluster' is also a
valid type.
Code is fine, so ACK if you fix the missing docs.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131218/4ef5db89/attachment-0001.sig>
More information about the libvir-list
mailing list