[libvirt] [PATCH 0/5] Fill qemucapabilitiesdata with some data

[Eric Blake]

On 10/03/2013 07:25 AM, Michal Privoznik wrote:
> The actual patches are accessible at:
> 
> git://gitorious.org/libvirt/michal-staging.git
> 
> branch test_qemu_capabilities_data
> 
> I'm not sending the actual patches as it's big junk of JSON qemu replies. The
> patches has from 35KiB to 59KiB. I don't want to overload the list.

While trying to backport this series, I noticed that:

>  tests/qemucapabilitiesdata/caps_1.2.2-1.caps     |  114 +
>  tests/qemucapabilitiesdata/caps_1.2.2-1.replies  | 1543 +++++++++++++

these .replies files are very hard to modify, when using a newer or
older version of libvirt that issues more or fewer JSON commands (that
is, the replies file is hardcoded to giving answers in the same order as
libvirt asks questions, but if the set or order of questions changes,
it's hard to see which answer(s) needs changing).  I would suggest that
we update the files to add a comment describing the JSON command issued
prior to each reply; the test should filter out the comments.  Doing
this will make it easier to modify the .replies files in the future if
we tweak qemu_capabilities.c to trigger more JSON commands even for
older qemu responses.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131219/2ea39c4a/attachment-0001.sig>