[libvirt] [PATCH] virnettlscontexttest fails with GNUTLS 3.0.28

[Cedric Bosdonnat]

Hi Eric,

On Thu, 2013-12-19 at 13:42 -0700, Eric Blake wrote:
> > -    DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename, GNUTLS_VERSION_MAJOR >= 3);
> > +    DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename,
> > +                GNUTLS_VERSION_MAJOR >= 3 && GNUTLS_VERSION_MINOR >= 1);
> 
> Not quite.  This will reject gnutls 4.0.  It has to be more like:
> 
> (GNUTLS_VERSION_MAJOR == 3 && GNUTLS_VERSION_MINOR >= 1) ||
> GNUTLS_VERSION_MAJOR > 3

Oops, indeed I'm wrong here.

> What distro were you on when you hit this failure?  I'm a little bit
> reluctant to bump the minimum requirement without knowing a bit more
> about how common 3.0 is in practice.  Adding more details in your commit
> log about why you needed it (not just what you changed) makes it easier
> to review.

I had the failure on all openSUSE 12.*

--
Cedric