[libvirt] [PATCH v3 2/4] conf: add support for panic device

[Eric Blake]

On 12/20/2013 06:59 AM, John Ferlan wrote:
> 
> 
> On 12/09/2013 04:11 AM, Hu Tao wrote:
> 
> <...snip...>
> 
>>  
>> +static bool
>> +virDomainPanicCheckABIStability(virDomainPanicDefPtr src,
>> +                                virDomainPanicDefPtr dst)
>> +{
>> +    return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info);

> 
> Unlike the virDomainRNGDefCheckABIStability() API, the new virDomainPanicCheckABIStability()
> has no checks for !src && !dst

Yay for automated regression testing catching something!  And sorry that
I missed this in my initial review.  Yes, adding or removing the panic
device is an ABI incompatibility.

> 
> I'll put together a patch for this, but figured I'd ask now if there were
> checks that should also be made in the PanicCheck API...

Not really - a panic device has only two properties: existence, and
address (the existence check is missing, which caused the core; but the
address check is already there).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131220/99edc5e1/attachment-0001.sig>