[libvirt] [PATCH] PanicCheckABIStability: Need to check for existence

[Eric Blake]

On 12/20/2013 11:10 AM, John Ferlan wrote:
> Commit id '4313fead' added a call to virDomainPanicCheckABIStability()
> which did not check whether the panic device existed before making a call
> to virDomainDeviceInfoCheckABIStability() which ended up segfaulting:
> 

> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 

> +++ b/src/conf/domain_conf.c
> @@ -13709,6 +13709,9 @@ static bool
>  virDomainPanicCheckABIStability(virDomainPanicDefPtr src,
>                                  virDomainPanicDefPtr dst)
>  {
> +    if (!src && !dst)
> +        return true;
> +
>      return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info);

Still crashes.  Minimal reproducer:

virsh save $dom $file
virsh save-image-edit $file
  add (or remove) a <panic/> line

This should fail ABI compatibility, not crash libvirtd.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131220/c9f1c87f/attachment-0001.sig>