[libvirt] [PATCH v2] PanicCheckABIStability: Need to check for existence

[Eric Blake]

On 12/21/2013 05:22 AM, John Ferlan wrote:
> Commit id '4313fead' added a call to virDomainPanicCheckABIStability()
> which did not check whether the panic device existed before making a call
> to virDomainDeviceInfoCheckABIStability() which ended up segfaulting:
> 

> Also seen using following sequence:
> 
> virsh save $dom $file
> virsh save-image-edit $file
>   add (or remove) a <panic/> line
>   <devices>
>   ...
>     <panic>
>       <address type='isa' iobase='0x505'/>
>     </panic>
>   ...
>   </devices>
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 
> Changes since v1 -
>    Added !src && !dst check, which results in:
> 
>  error: unsupported configuration: Target domain panic device count '0' does not match source count '1'

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131221/242051b9/attachment-0001.sig>