[libvirt] [PATCH 00/24] libvirt.c error handling audit

Eric Blake eblake at redhat.com
Sat Dec 28 16:11:35 UTC 2013


This series is in response to:
https://www.redhat.com/archives/libvir-list/2013-December/msg01101.html

It turned into a much bigger cleanup project, where I ended up
with a lot of changes; hopefully the division into multiple
patches makes review easier, and the end result diffstat shows
that the code base is more compact when all is said and done.

Eric Blake (24):
  maint: consistent formatting in libvirt.c
  maint: improve debug of libvirt-{qemu,lxc} apis
  maint: move debug statements first in public API
  maint: improve error condition style in public API
  maint: don't leave garbage on early API exit
  maint: reset error on entrance to public API
  maint: avoid nested public calls
  maint: improve VIR_ERR_NO_SUPPORT usage
  maint: improve VIR_ERR_OPERATION_DENIED usage
  maint: improve VIR_ERR_INVALID_CONN usage
  maint: inline VIR_IS_CONNECT macro
  maint: improve VIR_ERR_INVALID_DOMAIN usage
  maint: inline VIR_IS*_DOMAIN macro
  maint: improve VIR_ERR_INVALID_NETWORK usage
  maint: improve VIR_ERR_INVALID_INTERFACE usage
  maint: improve VIR_ERR_INVALID_STORAGE_POOL usage
  maint: improve VIR_ERR_INVALID_STORAGE_VOL usage
  maint: improve VIR_ERR_INVALID_NODE_DEVICE usage
  maint: improve VIR_ERR_INVALID_SECRET usage
  maint: improve VIR_ERR_INVALID_STREAM usage
  maint: improve VIR_ERR_INVALID_NWFILTER usage
  maint: improve VIR_ERR_INVALID_DOMAIN_SNAPSHOT usage
  maint: clean up error reporting in migration
  maint: replace remaining virLib*Error with better names

 cfg.mk                          |   10 -
 docs/api_extension.html.in      |    7 +-
 po/POTFILES.in                  |    1 -
 src/datatypes.c                 |  104 +-
 src/datatypes.h                 |  318 ++-
 src/internal.h                  |    9 +
 src/libvirt-lxc.c               |   38 +-
 src/libvirt-qemu.c              |   65 +-
 src/libvirt.c                   | 5342 +++++++++++++--------------------------
 src/locking/lock_daemon.c       |   16 +-
 src/lxc/lxc_driver.c            |    2 +-
 src/qemu/qemu_migration.c       |   10 +-
 src/security/security_manager.c |   46 +-
 src/util/virerror.c             |    2 +-
 src/util/virerror.h             |    8 +
 src/util/virinitctl.c           |    4 +-
 src/util/virtypedparam.c        |   14 +-
 src/util/viruuid.h              |   20 +-
 src/xen/xen_driver.c            |   11 +-
 19 files changed, 2250 insertions(+), 3777 deletions(-)

-- 
1.8.4.2




More information about the libvir-list mailing list