[libvirt] [PATCH 5/5] security: Remove unnecessary checks for mgr == NULL
Peter Krempa
pkrempa at redhat.com
Thu Feb 14 17:00:14 UTC 2013
On 02/14/13 17:42, John Ferlan wrote:
> Coverity found the DACGenLabel was checking for mgr == NULL after a
> possible dereference; however, in order to get into the function the
> virSecurityManagerGenLabel would have already dereferenced sec_managers[i]
> so the check was unnecessary. Same check is made in SELinuxGenSecurityLabel.
> ---
> src/security/security_dac.c | 6 ------
> src/security/security_selinux.c | 6 ------
> 2 files changed, 12 deletions(-)
>
Yep, probably a relic since layered security drivers were added.
ACK.
Peter
More information about the libvir-list
mailing list