[libvirt] [BUG] qemu internal snapshot with raw image not aborted

[Philipp Hahn]

Hello,

If the running VM contains a floppy, creating snapshot fails internally, but 
the error is not detected by libvirt. Success is still reported to the user 
success, who will see the snapshots, even they are NOT created.

virsh # qemu-monitor-command --hmp winxp-1  savevm \"test\"
Device 'drive-fdc0-0-0' is writable but does not support snapshots.

virsh # snapshot-create-as winxp-1 test
Domain snapshot test created

Since there is no QMP command in qemu, libvirtd sends a HMP command to the 
running QEMU and parses the returned text. There only the following 4 strings 
are detected as errors:

src/qemu/qemu_monitor_text.c:2822 # qemuMonitorTextCreateSnapshot()
"Error while creating snapshot"
"No block device can accept snapshots"
"Could not open VM state file"
"Error" + "while writing VM"

Since none of them match the above message, libvirts thinks the command 
succeeded.

libvirt-0.9.12 but also exists in git, QEMU 1.1.2

Tracked at <https://forge.univention.org/bugzilla/show_bug.cgi?id=30472>
-- 
Philipp Hahn           Open Source Software Engineer      hahn at univention.de
Univention GmbH        be open.                       fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/