[libvirt] [PATCH 13/14] virsh: Add migrate-compcache command

[Peter Krempa]

On 02/19/13 13:35, Jiri Denemark wrote:
> This is a command wrapping virDomainMigrateGetCompressionCache and
> virDomainMigrateSetCompressionCache.
> ---
>   tools/virsh-domain.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   tools/virsh.pod      | 12 ++++++++++
>   2 files changed, 80 insertions(+)
>
...
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index e675850..8f62378 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1114,6 +1114,18 @@ Set maximum tolerable downtime for a domain which is being live-migrated to
>   another host.  The I<downtime> is a number of milliseconds the guest is allowed
>   to be down at the end of live migration.
>
> +=item B<migrate-compcache> I<domain> [I<--size> B<bytes>]
> +
> +Sets and/or gets size of the cache (in bytes) used for compressing repeatedly
> +transferred memory pages during live migration. When called without I<size>,
> +the command just prints current size of the compression cache. When I<size>
> +is specified, the hypervisor is asked to change compression cache to I<size>
> +bytes and then the current size is printed (the result may differ from the
> +requested size due to rounding done by the hypervisor). With I<size> this

I'd rephrase as:

This command is supposed to be called with size while ...

> +command is supposed to be called while the domain is being live-migrated as
> +a reaction to migration progress and increasing number of compression cache
> +misses obtained from domjobinfo.
> +
>   =item B<migrate-setspeed> I<domain> I<bandwidth>
>
>   Set the maximum migration bandwidth (in Mbps) for a domain which is being
>

ACK.

Peter