[libvirt] [PATCH 01/10] conf: DHCP - add state for DHCP Relay and On/Off switch
Eric Blake
eblake at redhat.com
Thu Feb 28 04:45:27 UTC 2013
On 02/27/2013 08:49 PM, Eric Blake wrote:
>>> Your commit message is missing some substance, such as a summary of what
>>> is being added.
>>
>> The first line of the commit message is in the email subject, and describes the commit.
>>
>> "conf: DHCP - add state for DHCP Relay and On/Off switch"
>
> The summary is nice, but we also want to see a sample of the XML that
> you are adding. See, for example, commit 1716e7a6.
The summary in 6/10 is more what I was looking for; maybe it's worth
squashing that commit and this one into a single patch?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130227/71f68cf6/attachment-0001.sig>
More information about the libvir-list
mailing list