[libvirt] [PATCH v3 08/13] Rename all PCI device functions to have a standard name prefix
Daniel P. Berrange
berrange at redhat.com
Wed Feb 6 09:44:20 UTC 2013
On Tue, Feb 05, 2013 at 03:03:47PM -0700, Eric Blake wrote:
> On 02/05/2013 08:07 AM, Daniel P. Berrange wrote:
> > On Mon, Feb 04, 2013 at 06:31:10PM +0100, Jiri Denemark wrote:
> >> On Fri, Feb 01, 2013 at 11:18:30 +0000, Daniel P. Berrange wrote:
> >>> From: "Daniel P. Berrange" <berrange at redhat.com>
> >>>
> >>> Rename all the pciDeviceXXX and pciXXXDevice APIs to have a
> >>> fixed virPCIDevice name prefix
> >>
>
> >> ACK whether you implement changes I suggested or not (or just some of
> >> them) as long as make all check syntax-check succeeds.
> >
> > Will fix them all
>
> I believe this patch is the cause of my build failures on RHEL 6:
>
> CC libvirt_driver_nodedev_la-node_device_hal.lo
> cc1: warnings being treated as errors
> node_device/node_device_hal.c: In function 'gather_pci_cap':
> node_device/node_device_hal.c:151: error: implicit declaration of
> function 'pciGetPhysicalFunction' [-Wimplicit-function-declaration]
> node_device/node_device_hal.c:151: error: nested extern declaration of
> 'pciGetPhysicalFunction' [-Wnested-externs]
> node_device/node_device_hal.c:154: error: implicit declaration of
> function 'pciGetVirtualFunctions' [-Wimplicit-function-declaration]
> node_device/node_device_hal.c:154: error: nested extern declaration of
> 'pciGetVirtualFunctions' [-Wnested-externs]
Argh, the 'hal' driver - I knew there'd be something I'd miss. Will
put together a patch
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list