[libvirt] [PATCH 01/15] util: eliminate generic hook from virExecWithHook

Eric Blake eblake at redhat.com
Thu Feb 7 23:39:51 UTC 2013


On 02/07/2013 02:37 PM, Laine Stump wrote:
> virExecWithHook is only called from one place, so it always has the
> same "hook" function (virHookCommand), and the data sent to that
> function is always a virCommandPtr, so eliminate the function and
> generic data from the arglist, and replace it with "virCommandPtr
> cmd". The call to (hook)(data) is replaced with
> "virHookCommand(cmd)". Finally, virExecWithHook is renamed to virExec.
> 
> Indentation has been updated only for code that will remain after the
> next patch, which will remove all other args to virExec (since they
> are now redundant, as they're all members of virCommandPtr).
> ---
>  src/util/vircommand.c | 79 ++++++++++++++++++++++++---------------------------
>  1 file changed, 37 insertions(+), 42 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130207/c044551b/attachment-0001.sig>


More information about the libvir-list mailing list