[libvirt] [PATCH 4/4 v5] virsh: Use virNodeDeviceLookupSCSIHostByWWN

[Osier Yang]

On 2013年02月11日 21:18, Daniel P. Berrange wrote:
> On Mon, Feb 11, 2013 at 09:16:32PM +0800, Osier Yang wrote:
>> On 2013年02月07日 23:09, Daniel P. Berrange wrote:
>>> On Mon, Feb 04, 2013 at 10:16:44PM +0800, Osier Yang wrote:
>>>> Only nodedev-destroy and nodedev-dumpxml can benifit from the
>>>> new API, other commands like nodedev-detach only works for
>>>> PCI devices, WWN makes no sense for them.
>>>
>>> Is that really correct ? I thought we could use 'nodedev-detach' to
>>> delete an NPIV SCSI adapter, which would benefit from WWN wouldn't
>>> it ?
>>
>> nodedev-destroy can be used to delete the NPIV scsi adapter. Do we
>> also want to delete it using nodedev-detach? personally I think no
>> need, it just can introduce confusion.
>
> Oh yes, ignore my comment. I was mixing up the two commands
>

So, can you review this too? :-)

Osier