[libvirt] [PATCHv2 5/5] storage: test backing chain traversal

Peter Krempa pkrempa at redhat.com
Fri Feb 15 22:26:21 UTC 2013


On 02/15/13 21:38, Eric Blake wrote:
> Testing our backing chain handling will make it much easier to
> ensure that we avoid issues in the future.  If only I had written
> this test before I first caused several regressions...
>
> * tests/virstoragetest.c: New test.
> * tests/Makefile.am (test_programs): Build it.
> * .gitignore: Ignore new files.
> ---
>   .gitignore             |   1 +
>   tests/Makefile.am      |   6 +
>   tests/virstoragetest.c | 546 +++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 553 insertions(+)
>   create mode 100644 tests/virstoragetest.c

I just skimmed through this test as I don't feel well enough to review 
it thoroughly. It seems OK to me and it compiles and runs okay so I give 
a weak ACK.

Peter




More information about the libvir-list mailing list