[libvirt] [PATCH 0/6 v3] Shared disk table related fixes/improvements

Osier Yang jyang at redhat.com
Wed Feb 20 16:37:03 UTC 2013


On 2013年02月19日 20:27, Osier Yang wrote:
> Inspires by the crash when using CD-ROM or Floppy with empty source,
> except the fixes for the crashes, this also enrichs the hash table
> with a list of names of domain which use the shared disk. And to keep
> the hash table to be in consistent state, this also fixes the problems
> on adding/removing the hash entry when updateing/ejecting media of
> CD-ROM or Floppy. And updates the hash table when reconnecting domain
> process.
>
> v2 - v3:
>    * Rebase on the top
>    * Small changes after more testing.
>
> Osier Yang (6):
>    qemu: Add checking in helpers for sgio setting
>    qemu: Merge qemuCheckSharedDisk into qemuAddSharedDisk
>    qemu: Record names of domain which uses the shared disk in hash table
>    qemu: Update shared disk table when reconnecting qemu process
>    qemu: Move the shared disk adding and sgio setting prior to attaching
>    qemu: Remove the shared disk entry if the operation is ejecting or
>      updating
>
>   src/conf/domain_conf.c   |   20 ++++
>   src/conf/domain_conf.h   |    3 +
>   src/libvirt_private.syms |    1 +
>   src/qemu/qemu_conf.c     |  243 ++++++++++++++++++++++++++++++++++++++++++---
>   src/qemu/qemu_conf.h     |   26 ++++-
>   src/qemu/qemu_driver.c   |  108 ++++++++++++++++-----
>   src/qemu/qemu_hotplug.c  |   19 +----
>   src/qemu/qemu_hotplug.h  |    1 +
>   src/qemu/qemu_process.c  |   81 ++++------------
>   src/qemu/qemu_process.h  |    3 -
>   10 files changed, 377 insertions(+), 128 deletions(-)
>

Now pushed with commit message of 6/6 improved. And nits of 3/6, 4/6
fixed. Thanks for the reviewing.

Regards,
Osier




More information about the libvir-list mailing list