[libvirt] [PATCHv2 7/8] tests: Add tests for virtio-rng device handling
Eric Blake
eblake at redhat.com
Sat Feb 23 00:29:04 UTC 2013
On 02/21/2013 07:47 AM, Peter Krempa wrote:
> Adds XML parsing and qemu commandline tests for the VirtIO RNG device
> support.
> ---
>
> Notes:
> Version 2:
> - ACKed
>
> .../qemuxml2argv-virtio-rng-egd.args | 1 +
> .../qemuxml2argv-virtio-rng-egd.xml | 26 ++++++++++++++++++++++
> .../qemuxml2argv-virtio-rng-random.args | 1 +
> .../qemuxml2argv-virtio-rng-random.xml | 23 +++++++++++++++++++
> tests/qemuxml2argvtest.c | 5 +++++
> tests/qemuxml2xmltest.c | 3 +++
> 6 files changed, 59 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml
Is it worth testing that a filename containing an XML-special character
is properly escaped? Other than that, this one is still good to go.
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml
> @@ -0,0 +1,23 @@
> + <rng model='virtio'>
> + <backend model='random'>/test/phile</backend>
That is, should this use something like /test/<phile as the XML
encoded file name?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130222/fe456062/attachment-0001.sig>
More information about the libvir-list
mailing list