[libvirt] [PATCH 01/10] Check and handle error for virAsprintf() calls.
Daniel P. Berrange
berrange at redhat.com
Thu Jan 3 19:31:52 UTC 2013
On Thu, Jan 03, 2013 at 02:16:13PM -0500, John Ferlan wrote:
> ---
> src/interface/interface_backend_udev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c
> index cc20b98..3231b73 100644
> --- a/src/interface/interface_backend_udev.c
> +++ b/src/interface/interface_backend_udev.c
> @@ -654,9 +654,8 @@ udevIfaceGetIfaceDef(struct udev *udev, char *name)
> ifacedef->data.bridge.stp = stp;
>
> /* Members of the bridge */
> - virAsprintf(&member_path, "%s/%s",
> - udev_device_get_syspath(dev), "brif");
> - if (!member_path) {
> + if (virAsprintf(&member_path, "%s/%s",
> + udev_device_get_syspath(dev), "brif") < 0) {
> virReportOOMError();
> goto cleanup;
> }
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list