[libvirt] [PATCH 2/6] vmware: Avoid NULL dereference for 'caps'

John Ferlan jferlan at redhat.com
Mon Jan 7 17:09:30 UTC 2013


When virCapabilitiesNew() fails, caps will be NULL resulting in possible
core when deref'd in cpuDataFree() call.
---
 src/vmware/vmware_conf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
index b514636..fd9c473 100644
--- a/src/vmware/vmware_conf.c
+++ b/src/vmware/vmware_conf.c
@@ -127,7 +127,8 @@ vmwareCapsInit(void)
 
 cleanup:
     virCPUDefFree(cpu);
-    cpuDataFree(caps->host.arch, data);
+    if (caps)
+        cpuDataFree(caps->host.arch, data);
 
     return caps;
 
-- 
1.7.11.7




More information about the libvir-list mailing list