[libvirt] [PATCH 13/14] storage: Need to also VIR_FREE(reg)
Ján Tomko
jtomko at redhat.com
Wed Jan 9 15:31:45 UTC 2013
On 01/09/13 15:54, John Ferlan wrote:
> Commit-id 'afc4631b' added the regfree(reg) to free resources alloc'd
> during regcomp; however, reg still needed to be VIR_FREE()'d.
> ---
> src/storage/storage_backend_logical.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
> index bd902fe..38b9f08 100644
> --- a/src/storage/storage_backend_logical.c
> +++ b/src/storage/storage_backend_logical.c
> @@ -265,6 +265,7 @@ virStorageBackendLogicalMakeVol(virStoragePoolObjPtr pool,
> cleanup:
> VIR_FREE(regex);
> regfree(reg);
> + VIR_FREE(reg);
> VIR_FREE(vars);
> if (is_new_vol && (ret == -1))
> virStorageVolDefFree(vol);
Eww, who did that? O:-)
Now I see it's not the only thing wrong with my fix, since regfree
doesn't accept NULL.
Jan
More information about the libvir-list
mailing list