[libvirt] [PATCH 2/2] spec: indent %if to make it easier to see conditions

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Thu Jan 10 13:07:59 UTC 2013


On 01/10/2013 12:50 PM, Daniel P. Berrange wrote:

> IIUC, RPM will expand macros *anywhere* in the spec file, even
> in places you don't want it to like comments ! So I don't think
> adding some whitespace will harm things
>
Technically absolutely true. I was thinking more about potential
formatting conventions used by distribution packagers. The
packaging rules I've seen don't explicitly mention indentation, so one
could infer it doesn't matter and it is merely an esthetic question.
But then beauty is in the eye of the beholder...

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list