[libvirt] [PATCH v2 2/2] qemu: add usb-serial support

[Guannan Ren]

On 01/08/2013 07:12 AM, Eric Blake wrote:
> This renders as:
>
> sub-element <address> with type='usb'which can tie
>
> You are missing a space, and it also sounds funny, so I suggest:
>
> s/which / /

     fixed.

>
>> @@ -994,6 +1001,8 @@ struct _virDomainChrSourceDef {
>>   /* A complete character device, both host and domain views.  */
>>   struct _virDomainChrDef {
>>       int deviceType;
>> +
>> +    bool targetTypeAttr;
> We still haven't answered the question of whether it is better to update
> all tests to add an output of explicit type='isa-serial' even when
> omitted on input (and this bool is not needed), or whether your approach
> of doing output only when present on input makes more sense.  If the
> former, then we need a v3 that touches all affected tests; if the
> latter, then ACK to this patch with the doc fix.
>

    I prefer the latter without no third opinion.
    Thanks for the review.
    Pushed.