[libvirt] [PATCH 02/10] security: Use virStrcpy to move the label

John Ferlan jferlan at redhat.com
Thu Jan 17 19:17:07 UTC 2013


---
 src/security/security_dac.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index deff024..7ef7eb9 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -995,7 +995,13 @@ virSecurityDACGetProcessLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
         return -1;
 
     if (secdef->label)
-        strcpy(seclabel->label, secdef->label);
+        if (!virStrcpy(seclabel->label, secdef->label,
+                       VIR_SECURITY_LABEL_BUFLEN)) {
+            virReportError(VIR_ERR_INTERNAL_ERROR,
+                           _("security label exceeds max %d bytes"),
+                           VIR_SECURITY_LABEL_BUFLEN-1);
+            return -1;
+        }
 
     return 0;
 }
-- 
1.7.11.7




More information about the libvir-list mailing list