[libvirt] [PATCH] Have a colorful nodedev.rng with vi

Osier Yang jyang at redhat.com
Wed Jan 23 15:08:22 UTC 2013


On 2013年01月19日 00:56, Eric Blake wrote:
> On 01/18/2013 02:19 AM, Osier Yang wrote:
>> Just add the head line to let vi known it's a XML document.
>
> s/known/know/
>
>> ---
>>   docs/schemas/nodedev.rng |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> ACK to the idea, but before you push...
>
>>
>> diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng
>> index 7c85815..04d8ee9 100644
>> --- a/docs/schemas/nodedev.rng
>> +++ b/docs/schemas/nodedev.rng
>> @@ -1,3 +1,4 @@
>> +<?xml version="1.0"?>
>
> Please extend this to cover ALL of the .rng files; right now, my quick
> grep showed two other culprits that need the same fix (vs. 11 that were
> correct):
>
> $ grep -l -L '?xml version=.1' docs/schemas/*.rng
> docs/schemas/capability.rng
> docs/schemas/nodedev.rng
> docs/schemas/storageencryption.rng
>

Yeah, the grep result is correct. I extended the patch and pushed.
Thanks.

Osier




More information about the libvir-list mailing list