[libvirt] [libvirt-java] Add various block, snapshot and migrate methods

Wido den Hollander wido at widodh.nl
Wed Jan 23 15:19:43 UTC 2013


Hello Claudio,

On 01/23/2013 04:13 PM, Claudio Bley wrote:
> Hello Wido,
>
> At Sun, 13 Jan 2013 19:09:22 +0100,
> Wido den Hollander wrote:
>>
>> Hi,
>>
>> I've sent a series of patches like these about two weeks ago and got
>> some great feedback from Claudio on those!
>>
>> The feedback from Claudio has been used for writing this series of patches.
>>
>> Backwards compatibility has been preserved by still using virDomainMigrate
>> and virtDomainMigrateToUri for the exisiting methods, just to be sure.
>
> I have reviewed your changeset and basically it's OK with a few nits fixed.
>
> If you or somebody else doesn't have any objections I'd push the whole
> series.
>

Thank you! I just saw your comments coming in.

Since I don't know what  the convention is for libvirt-java I followed 
most of the existing code with the implementation.

Your feedback sounds good, so no objections from my side.

Wido

> Claudio
>




More information about the libvir-list mailing list