[libvirt] [PATCH 2/1] maint: make it easier to sort syms files
Daniel P. Berrange
berrange at redhat.com
Thu Jan 24 09:44:22 UTC 2013
On Wed, Jan 23, 2013 at 06:23:56PM -0700, Eric Blake wrote:
> I got bit by 'make check' complaining that the sort order I got
> by emacs' sort-lines function differed from expectations.
>
> * src/libvirt_private.syms: Add emacs trailer.
> ---
>
> Okay to push this as well? My previous patch mistakenly did this:
> > +++ b/src/libvirt_private.syms
> > @@ -487,10 +487,12 @@ virDomainObjSetState;
> > virDomainObjTaint;
> > virDomainPausedReasonTypeFromString;
> > virDomainPausedReasonTypeToString;
> > -virDomainPciRombarModeTypeFromString;
> > -virDomainPciRombarModeTypeToString;
> > virDomainPMStateTypeFromString;
> > virDomainPMStateTypeToString;
> > +virDomainPMSuspendedReasonTypeFromString;
> > +virDomainPMSuspendedReasonTypeToString;
> > +virDomainPciRombarModeTypeFromString;
> > +virDomainPciRombarModeTypeToString;
> > virDomainRedirdevBusTypeFromString;
>
> I didn't catch that until 'make check' after I had already posted;
> I've fixed that sorting locally, but this patch would let me avoid
> the same problem in the future.
>
> src/libvirt_private.syms | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 1f0e4cf..db2ff62 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -1910,3 +1910,8 @@ virXPathUInt;
> virXPathULong;
> virXPathULongHex;
> virXPathULongLong;
> +
> +# Let emacs know we want case-insensitive sorting
> +# Local Variables:
> +# sort-fold-case: t
> +# End:
> --
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list