[libvirt] [PATCH 2/5] security: Need to add virCommandFree()
Michal Privoznik
mprivozn at redhat.com
Thu Jan 24 11:40:31 UTC 2013
On 23.01.2013 23:04, John Ferlan wrote:
> ---
> src/security/security_apparmor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c
> index 7331c91..6dcf6be 100644
> --- a/src/security/security_apparmor.c
> +++ b/src/security/security_apparmor.c
> @@ -201,6 +201,7 @@ load_profile(virSecurityManagerPtr mgr,
>
> virCommandSetInputBuffer(cmd, xml);
> rc = virCommandRun(cmd, NULL);
> + virCommandFree(cmd);
>
> clean:
> VIR_FREE(xml);
>
While technically, your patch is correct, I prefer having virCommandFree
within cleanup label (yeah, there's just 'clean').
Michal
More information about the libvir-list
mailing list