[libvirt] [PATCH v3 04/13] libvirt.h.in: document virConnectDomainEventCallback's return value

[Eric Blake]

On 01/30/2013 08:38 AM, Claudio Bley wrote:
> 
> Signed-off-by: Claudio Bley <cbley at av-test.de>
> ---
>  include/libvirt/libvirt.h.in |    2 ++
>  1 file changed, 2 insertions(+)

Hmm, I wonder if we should at least log any situation where the user's
callback returns non-zero, rather than flat-out ignoring it.

But I suppose this works well enough for the moment; ACK.

> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 4222fe1..30762b1 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -3441,6 +3441,8 @@ typedef enum {
>   * @opaque: opaque user data
>   *
>   * A callback function to be registered, and called when a domain event occurs
> + *
> + * Returns 0 (the return value is currently ignored)
>   */
>  typedef int (*virConnectDomainEventCallback)(virConnectPtr conn,
>                                               virDomainPtr dom,
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130131/f3e5c1b0/attachment-0001.sig>