[libvirt] [PATCH 0/2] spec file cleanups

Eric Blake eblake at redhat.com
Wed Jan 9 23:45:10 UTC 2013


While working on recent tarball issues, I noticed the spec file
was hard to read.  In developing the second patch for my own
sanity, I found some cleanups that I separated out to the first
patch.  I don't know if you want to apply the second patch, and
even if you do, it might be nice if 'cppi' could be enhanced to
enforce indentation rules in spec files the same way it does
for preprocessor rules in .c files (maybe even by using a
judicious tr to turn %if into #if of a temporary file, so that
existing cppi could do it); without enforcement, I'm afraid the
second patch will be quickly fall back into hard-to-read status.

Eric Blake (2):
  spec: remove redundant %if
  spec: indent %if to make it easier to see conditions

 libvirt.spec.in | 864 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 428 insertions(+), 436 deletions(-)

-- 
1.8.0.2




More information about the libvir-list mailing list