[libvirt] [PATCH] domain controller index check

Jincheng Miao jmiao at redhat.com
Tue Jul 9 04:07:30 UTC 2013


On 07/08/2013 11:04 PM, jtomko at redhat.com wrote:
>I wonder if we should forbid values larger than INT_MAX as well, since
>virDomainDefRejectDuplicateControllers uses -1 as 'no controllers' and
>qemuDomainAssignPCIAddresses uses it for 'no PCI buses'.

>If it overflowed, this could result in some weird errors (but that many PCI
>bridges wouldn't be usable anyway).

>Jan

Yes, you are right. Thanks for your kind mention. 
The index value should be limited in INT_MAX. 
I will resent the patch.




More information about the libvir-list mailing list