[libvirt] [PATCH v2 01/37] viralloc: Report OOM error on failure

Peter Krempa pkrempa at redhat.com
Wed Jul 10 08:47:21 UTC 2013


On 07/09/13 17:09, Michal Privoznik wrote:
> Similarly to VIR_STRDUP, we want the OOM error to be reported in
> VIR_ALLOC and friends.
> ---
>   po/POTFILES.in                  |   1 +
>   python/libvirt-override.c       | 102 +++++++++---------
>   src/conf/domain_conf.c          |  15 +--
>   src/conf/network_conf.c         |  50 ++++-----
>   src/esx/esx_vi.c                |   2 +-
>   src/lxc/lxc_process.c           |   8 +-
>   src/security/security_manager.c |   2 +-
>   src/security/security_selinux.c |   3 +-
>   src/util/viralloc.c             | 166 ++++++++++++++++++++++++----
>   src/util/viralloc.h             | 234 ++++++++++++++++++++++++++++++++++------
>   src/util/virbuffer.c            |   8 +-
>   src/util/vircgroup.c            |   2 +-
>   src/util/virerror.c             |   4 +-
>   src/util/virlog.c               |  12 +--
>   src/util/virpci.c               |   4 +-
>   src/util/virthreadpthread.c     |   2 +-
>   tests/commandhelper.c           |   1 +
>   tests/networkxml2conftest.c     |   2 +
>   tests/test_conf.c               |   2 +-
>   tests/xmconfigtest.c            |   2 +
>   20 files changed, 459 insertions(+), 163 deletions(-)
>

ACK, you addressed my most critical comments.

Peter




More information about the libvir-list mailing list