[libvirt] [PATCH v2 2/7] storage: Support "username" for "chap" type "auth"

[Osier Yang]

On 10/07/13 22:49, Daniel P. Berrange wrote:
> On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote:
>> To be consistent with "ceph" types for storage "auth" elements, allow
>> "username" to be used as an "auth" attribute name for "chap" types.
>> Continue to allow "login" for backwards compatibility when reading the XML,
>> but when writing the XML use "username".
> Hmm, so the schema for 'chap' auth is utterly awful.
>
> While we have parsed this schema for a while, nothing in the libvirt
> codebase has ever used 'chap' auth.

i didn't realize this.

> As such I think we have reasonable grounds for just discarding the
> existing code for parsing 'chap' auth and doing it right. ie use
> the same terminology as 'ceph' and do not include the 'password'
> value in the XML at all.

agreed. silently ignoring the 'login'and 'passwd' is fine, there are
no documentations for the two attrs too.

> Thoughts ?
>
> Daniel