[libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

[Paolo Bonzini]

Il 24/07/2013 12:39, Daniel P. Berrange ha scritto:
> On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote:
>> Il 24/07/2013 12:31, Daniel P. Berrange ha scritto:
>>> breaking the default config for QEMU's without iSCSI support.
>>
>> Understood, that's why I suggested not having a default config at all
>> for type='lun' devices.
> 
> As I said before, that causes apps to have to do special handling
> for iSCSI pools, which is not something we want.

This is not about iSCSI pools, it is about type='lun' devices.

And as I said before, knowing the kind of pool is something you have to
do anyway for type='lun' devices, because they won't work if the
underlying pool is filesystem- or LVM-based.

>> Also, can libvirt at least detect using a volume on a pool that wasn't
>> started, and fail unless mode='direct'?
> 
> It should always fail to start the guest if the pool is not started,
> regardless of the mode used.

Another point of mode='direct' is that the pool need not be started.

Paolo