[libvirt] [PATCH] python: Drop TODO

Cole Robinson crobinso at redhat.com
Mon Jul 29 11:55:24 UTC 2013


File hasn't been really touched for 7 years. And with recent rawhide
changes it contributed to an RPM build failure. Let's drop it.

This also removes installation of a libvirt-python doc dir, so drop
handling of it from the RPM spec.
---
 libvirt.spec.in    | 7 -------
 python/Makefile.am | 7 -------
 python/TODO        | 6 ------
 3 files changed, 20 deletions(-)
 delete mode 100644 python/TODO

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e0e0004..81101e8 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1440,12 +1440,6 @@ rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/libvirtd_lxc.aug
 rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/tests/test_libvirtd_lxc.aug
 %endif
 
-%if ! %{with_python}
-rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-python-%{version}
-%else
-rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-python-%{version}/examples
-%endif
-
 %if ! %{with_qemu}
 rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu.conf
 rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.qemu
@@ -2060,7 +2054,6 @@ fi
 %{_libdir}/python*/site-packages/libvirt_lxc.py*
 %{_libdir}/python*/site-packages/libvirtmod*
 %doc python/tests/*.py
-%doc python/TODO
 %doc examples/python
 %doc examples/domain-events/events-python
 %endif
diff --git a/python/Makefile.am b/python/Makefile.am
index 9e957d1..7eb42c6 100644
--- a/python/Makefile.am
+++ b/python/Makefile.am
@@ -31,10 +31,6 @@ INCLUDES = \
 
 AM_CFLAGS = $(WARN_CFLAGS)
 
-DOCS_DIR = $(datadir)/doc/libvirt-python-$(VERSION)
-
-DOCS = ${srcdir}/TODO
-
 CLASSES_EXTRA = \
 	libvirt-override-virConnect.py \
 	libvirt-override-virDomain.py \
@@ -152,9 +148,6 @@ install-data-local:
 	$(INSTALL) -m 0644 libvirt.py $(DESTDIR)$(pyexecdir)
 	$(INSTALL) -m 0644 libvirt_lxc.py $(DESTDIR)$(pyexecdir)
 	$(INSTALL) -m 0644 libvirt_qemu.py $(DESTDIR)$(pyexecdir)
-	$(mkinstalldirs) $(DESTDIR)$(DOCS_DIR)
-	@(for doc in $(DOCS) ; \
-	   do $(INSTALL) -m 0644 $$doc $(DESTDIR)$(DOCS_DIR) ; done)
 
 uninstall-local:
 	rm -f $(DESTDIR)$(pyexecdir)/libvirt.py
diff --git a/python/TODO b/python/TODO
deleted file mode 100644
index 4627482..0000000
--- a/python/TODO
+++ /dev/null
@@ -1,6 +0,0 @@
-- Need to complete, add custom wrapper function for those
-  which could not be handled fully automatically
-- Check the names generated, iD is bad, fix the name generation routine
-- add examples, web page and python based test suite
-
-Daniel Veillard
-- 
1.8.3.1




More information about the libvir-list mailing list