[libvirt] [PATCH 08/32] Convert 'int i' to 'size_t i' in src/storage/ files
Ján Tomko
jtomko at redhat.com
Tue Jul 9 11:28:10 UTC 2013
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Convert the type of loop iterators named 'i', 'j', k',
> 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
> 'unsigned int', also santizing 'ii', 'jj', 'kk' to use
> the normal 'i', 'j', 'k' naming
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/storage/storage_backend.c | 8 ++++----
> src/storage/storage_backend_disk.c | 6 +++---
> src/storage/storage_backend_fs.c | 2 +-
> src/storage/storage_backend_iscsi.c | 2 +-
> src/storage/storage_backend_logical.c | 10 ++++++----
> src/storage/storage_backend_rbd.c | 4 ++--
> src/storage/storage_driver.c | 19 +++++++++++--------
> 7 files changed, 28 insertions(+), 23 deletions(-)
>
> @@ -264,7 +264,7 @@ static int virStorageBackendRBDRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
> size_t max_size = 1024;
> int ret = -1;
> int len = -1;
> - int i;
> + size_t i;
This one seems pointless, since we never read its value.
> char *name, *names = NULL;
> virStorageBackendRBDStatePtr ptr;
> ptr.cluster = NULL;
ACK
Jan
More information about the libvir-list
mailing list