[libvirt] [PATCH v2 1/3] libxl: implement NUMA capabilities reporting
Dario Faggioli
dario.faggioli at citrix.com
Wed Jul 10 09:01:13 UTC 2013
On mar, 2013-07-09 at 16:21 -0600, Jim Fehlig wrote:
> > static virCapsPtr
> > +libxlMakeNumaCapabilities(libxl_numainfo *numa_info,
> > + int nr_nodes,
> > + libxl_cputopology *cpu_topo,
> > + int nr_cpus,
> > + virCapsPtr caps)
> > +{
> > + virCapsHostNUMACellCPUPtr *cpus = NULL;
> > + int *nr_cpus_node = NULL;
> > + bool numa_failed = false;
> > + int i;
> >
>
> BTW, the 'i' and 'j' iterators should be changed to size_t. danpb has a
> patchset to sanitize iterators that will be committed any time now, so
> might as well make this change in your next version
>
Yep, I saw that, and I will.
Thanks,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130710/2b350dd9/attachment-0001.sig>
More information about the libvir-list
mailing list