[libvirt] Why does libvirt not unlink qemu-ga or any other socket in function qemuProcessStop()

[Daniel P. Berrange]

On Wed, Jul 17, 2013 at 08:14:35AM +0000, Wangyufei (A) wrote:
> Hello,
> I have defined a vm with two UNIX domain sockets. One is for qemu-ga and the
> other is for my service. These two devices will act as UNIX domain socket
> server. They are automatically generated by qemu. But when the vm was dead,
> these two sockets were not deleted. I find that libvirt will unlink vm's
> monitor socket(/var/lib/libvirt/qemu) in function qemuProcessStop(). Why
> does libvirt not unlink qemu-ga or any other socket in function qemuProcessStop()?

I guess it just never occurred to anyone to implement code to unlink these
other unix sockets. While QEMU could unlink them itself, a crashing QEMU
certainly would not, so it would be good practice for libvirt to explicitly
clean up any UNIX domain sockets after a guest shuts down.

If you want to add such clean up code, please do send a patch. If you can't
write it yourself, then at least file a bug to record this issue, so that
we can track the issue.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|